Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCM: set predictable and proper server IP addresses order #884

Merged
merged 2 commits into from
Jan 15, 2020
Merged

CCM: set predictable and proper server IP addresses order #884

merged 2 commits into from
Jan 15, 2020

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Dec 19, 2019 •
edited by lingxiankong
Loading

The binaries affected:

  • openstack-cloud-controller-manager
  • cinder-csi-plugin
  • k8s-keystone-auth
  • client-keystone-auth
  • octavia-ingress-controller
  • manila-csi-plugin
  • manila-provisioner
  • magnum-auto-healer
  • barbican-kms-plugin

What this PR does / why we need it:

This PR sets predictable server IP addresses order:

  1. interfaces private IPs
  2. access IPs
  3. metadata hostname
  4. server object Addresses

Which issue this PR fixes:
fixes #863

Release note:

openstack-cloud-controller-manager: Support predictable and proper server IP addresses search order.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kayrus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2019
@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 19, 2019

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 19, 2019

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 19, 2019

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 19, 2019

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 19, 2019

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 19, 2019

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 19, 2019

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 19, 2019

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 19, 2019

Build succeeded.

@kayrus kayrus changed the title CCM: set predicted and proper server IP addresses order CCM: set predictable and proper server IP addresses order Dec 19, 2019
@kayrus
Copy link
Contributor Author

kayrus commented Dec 20, 2019

/assign @lingxiankong @adisky

@lingxiankong
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@kayrus kayrus force-pushed the ordered-interfaces branch from d9f8413 to 9256f02 Compare January 8, 2020 07:45
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@kayrus
Copy link
Contributor Author

kayrus commented Jan 8, 2020

/test cloud-provider-openstack-e2e-test-csi-cinder

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build failed.

@kayrus
Copy link
Contributor Author

kayrus commented Jan 8, 2020

/test cloud-provider-openstack-e2e-test-csi-cinder

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build failed.

@kayrus
Copy link
Contributor Author

kayrus commented Jan 8, 2020

/test cloud-provider-openstack-e2e-test-csi-cinder

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2020

Build succeeded.

@kayrus
Copy link
Contributor Author

kayrus commented Jan 9, 2020

@lingxiankong kindly ping

1 similar comment
@kayrus
Copy link
Contributor Author

kayrus commented Jan 14, 2020

@lingxiankong kindly ping

@lingxiankong
Copy link
Contributor

Hi @kayrus, sorry for the delay, i was distracted by some internal stuff these days, will try to come back for review tomorrow.

@lingxiankong
Copy link
Contributor

Thanks for this fix!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 46cab81 into kubernetes:master Jan 15, 2020
@kayrus kayrus deleted the ordered-interfaces branch January 16, 2020 05:23
@kayrus kayrus mentioned this pull request Apr 20, 2020
Closed
@kayrus kayrus mentioned this pull request Oct 7, 2020
Closed
@kayrus kayrus mentioned this pull request Jan 15, 2021
Merged
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@kayrus @k8s-ci-robot
CCM: set predictable and proper server IP addresses order (kubernetes…
67bc81b 
…#884)

* CCM: set predicted and proper server ip addresses order

* code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingxiankong lingxiankong lingxiankong requested changes

@dims dims Awaiting requested review from dims

Assignees

@lingxiankong lingxiankong

@adisky adisky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CCM: Incorrect network interfaces order, when multiple interfaces are used
4 participants
@kayrus @k8s-ci-robot @lingxiankong @adisky